Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing cstdint header in latest gcc build #853

Merged
merged 2 commits into from
May 23, 2023
Merged

Fix missing cstdint header in latest gcc build #853

merged 2 commits into from
May 23, 2023

Conversation

zaidhaan
Copy link
Contributor

🦟 Bug fix

Same as gazebosim/gz-common#512, build fails on GCC 13.1.1 due to a missing <cstdint> header.

Summary

Adds missing <cstdint> to GraphicsAPI.hh

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@zaidhaan zaidhaan requested a review from iche033 as a code owner May 21, 2023 18:39
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 21, 2023
@codecov
Copy link

codecov bot commented May 22, 2023 •
edited
Loading

Codecov Report

Merging #853 (337f326) into gz-rendering7 (ef4abec) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 337f326 differs from pull request most recent head ffffdfb. Consider uploading reports for the commit ffffdfb to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering7     #853   +/-   ##
==============================================
  Coverage          77.14%   77.14%           
==============================================
  Files                170      170           
  Lines              14716    14716           
==============================================
+ Hits               11352    11353    +1     
+ Misses              3364     3363    -1

see 1 file with indirect coverage changes

@mjcarroll
Copy link
Contributor

The CI failures here seem unrelated to the change at hand.

@mjcarroll mjcarroll merged commit 3bf3a64 into gazebosim:gz-rendering7 May 23, 2023
@mjcarroll mjcarroll mentioned this pull request May 23, 2023
Merged
@zaidhaan zaidhaan deleted the fix-missing-cstdint branch May 23, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zaidhaan @mjcarroll @ahcorde @iche033